feat: improve learn ahead and timebox dialogs#20485
Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom Mar 15, 2026
Merged
Conversation
Contributor
|
Important Maintainers: This PR contains Strings changes
|
Member
|
Can I confirm you've read our AI policy: https://github.com/ankidroid/Anki-Android/blob/main/AI_POLICY.md#new-contributors
|
Contributor
Author
|
Yes, I have read the AI policy. I'll remove the duplicate string and use Rstring.save insted |
ff366eb to
4eaf673
Compare
Contributor
Author
|
Fixed. Anything else to improve. |
david-allison
approved these changes
Mar 15, 2026
david-allison
approved these changes
Mar 15, 2026
Member
david-allison
left a comment
There was a problem hiding this comment.
If you request a review, it removes my previous one
4eaf673 to
0886124
Compare
BrayanDSO
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
The "Learn ahead limit" and "Timebox time limit" dialogs use a plain text input. This PR improves them by adding stepper buttons and changing "OK" to "Save".
Fixes
Approach
Switched both preferences in
preferences_reviewing.xmlfromNumberRangePreferenceCompattoIncrementerNumberRangePreferenceCompatwhich already has +/- stepper buttons and input validation built in. Addeddialog_savestring to03-dialogs.xmland updated the positive button text inIncrementerNumberRangePreferenceCompatto use it.This addresses the required changes from the issue. The optional changes (unit label and description text) are not included in this PR and can be done separately.
How Has This Been Tested?
Built with
assembleDebugand tested both dialogs on emulator (API 36).