improvements on card type dialogs#20488
Open
nourhanbakry wants to merge 6 commits intoankidroid:mainfrom
Open
Conversation
rename: show red text when card type name used remove (:) from text field label add dialog with text field for card type name when adding new card type and with add button edit remove card title and button
Contributor
|
Important Maintainers: This PR contains Strings changes
|
Contributor
|
@nourhanbakry Edit: Some info: Contributing guidelines don't allow multiple commits. |
Contributor
|
Also make sure to not make many commits, use rebase or use (git --amend --no-edit) to make changes in the same commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Improvements on card type dialogs
Fixes
Approach
How Has This Been Tested?
Through android emulator API 33 and here are results
Checklist