Skip to content

improvements on card type dialogs#20488

Open
nourhanbakry wants to merge 6 commits intoankidroid:mainfrom
nourhanbakry:Improve-the-card-type-dialogs
Open

improvements on card type dialogs#20488
nourhanbakry wants to merge 6 commits intoankidroid:mainfrom
nourhanbakry:Improve-the-card-type-dialogs

Conversation

@nourhanbakry
Copy link

Purpose / Description

Improvements on card type dialogs

  • show red text when card type name used
  • remove (:) from text field label
  • add dialog with text field for card type name when adding new card type and with add button
  • edit remove card title and button (Replace "OK" with "Delete" , Change the title to "Delete card type")

Fixes

Approach

  • Added a TextWatcher to the EditText in RenameCardTemplateDialog to detect duplicate names
  • Disabled the "Rename" button if the name already exists
  • Added a warning TextView in red to show duplicate name message
  • Used actionsNewNameClean() extension function on translation to remove colon from the text field label
  • Updated AddCardTypeDialog to include a text field for entering new card type name and an "Add" button
  • Modified RemoveCardDialog: changed title to "Delete card type" and button text to "Delete"

How Has This Been Tested?

Through android emulator API 33 and here are results

Screenshot 1 Screenshot 2 Screenshot 3 Screenshot 4

Checklist

  • [✅] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [✅] You have commented your code, particularly in hard-to-understand areas
  • [✅] You have performed a self-review of your own code
  • [✅] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [✅] UI Changes: You have tested your change using the Google Accessibility Scanner

rename: show red text when card type name used
remove (:) from text field label
add dialog with text field for card type name when adding new card type and with add button
edit remove card title and button
@github-actions
Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@BinaryBhaskar
Copy link
Contributor

BinaryBhaskar commented Mar 16, 2026

@nourhanbakry
Make sure to read CONTRIBUTING as well as AI POLICY

Edit: Some info: Contributing guidelines don't allow multiple commits.

@Ayush-Patel-56
Copy link
Contributor

Also make sure to not make many commits, use rebase or use (git --amend --no-edit) to make changes in the same commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the card type dialogs

3 participants