Improve custom sync server and AnkiDroid directory dialogs#20489
Open
dagangtj wants to merge 1 commit intoankidroid:mainfrom
Open
Improve custom sync server and AnkiDroid directory dialogs#20489dagangtj wants to merge 1 commit intoankidroid:mainfrom
dagangtj wants to merge 1 commit intoankidroid:mainfrom
Conversation
- Capitalize 'url' to 'URL' in sync server dialog - Add border to input boxes (URL, PEM, Directory) - Replace 'OK' button with 'Save' button Fixes ankidroid#20487
Contributor
|
Important Maintainers: This PR contains Strings changes
|
Contributor
|
Hi @dagangtj, kindly follow the standard PR template. |
Contributor
|
Hi @dagangtj 👋 It would be good to follow the suggestion mentioned by @Ayush-Patel-56 and update the PR description according to the template.Since this PR changes some dialog UI, adding screenshots of the updated dialogs would also help. Its good practice for future PRs as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the custom sync server and AnkiDroid directory dialogs as requested in #20487.
Changes
Implementation Details
edittext_border.xmldrawable with 1dp stroke and 4dp corner radiusVersatileTextPreference.ktto apply border and change button textTesting
Fixes #20487