feat(card-browser): field selection dialog for advanced searches [DEV ONLY]

[david-allison]

Purpose / Description

In #20071 I introduced an 'advanced search' feature in dev for the card browser. This PR improves this feature for the 'Fields' tab

Tapping any but the last option opens up a FieldSelectionDialog, so we can replace field with the field name. This also allows us to remove the Search a field with a space in the name option, as we use buildSearchString to handle this case.

Change to the search text after tapping

- field:*text* 
+ "Add Reverse:*text*" 

Fixes

• Part of Card Browser: Migrate to Material 3 SearchView #18709

Approach

1. Use OptionType to support extension
2. Add FieldSelectionDialog, which uses the Fragment Result API to communicate
3. Define a new OptionType, add most of the logic which handles this in AdvancedSearchFieldsTab, and have AdvancedSearchFragment coordinate between this and the FieldSelectionDialog

FieldSelectionDialog has a number of extension points which mean that it will differ from InsertFieldDialog

InsertFieldDialog

• To be extended to handle special fields
• To be extended to handle field filters
• Typically used to list the fields of 1 note type

FieldSelectionDialog

• For fields of all note types
• To be extended to handle searching
• To be extended to handle filtering by note type

How Has This Been Tested?

card_browser_fields.webm

Learning (optional, can help others)

Collection.buildSearchString

field = front; text = "*a*" returns front:\*a\* with no way to avoid escaping. Many of the strings which we are replacing use *, so this is hacked around

---

https://docs.ankiweb.net/searching.html#limiting-to-a-field

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

Optional: should I change the dialog title to match the option title?

[ZornHadNoChoice]

Instead of "text", why not place the cursor there so the user can immediately type the actual text?

I prefer just "Select field" in the title since it makes it clearer that you're meant to select a field. Also, because of this dialog:

UI design is tough

I looked at the material 3 guidelines for dialogs and they actually state that "headlines" are optional, but the supporting text and the button text are not?!

To make it more confusing, Google Calendar has this dialog:

and Gmail has this: