Fix #20475 improve labels in Deck dialogs#20492
Open
UdaybhanRaj-Dev wants to merge 1 commit intoankidroid:mainfrom
Open
Fix #20475 improve labels in Deck dialogs#20492UdaybhanRaj-Dev wants to merge 1 commit intoankidroid:mainfrom
UdaybhanRaj-Dev wants to merge 1 commit intoankidroid:mainfrom
Conversation
Contributor
|
Important Maintainers: This PR contains Strings changes
|
Contributor
|
Hi. Just a couple of suggestions:
|
Author
Thank you for the suggestions. I have shortened the commit message and updated the PR description with the checklist and testing details. |
2caf48f to
b4ac4fd
Compare
Contributor
|
Hi @UdaybhanRaj-Dev, using semantic commits is a good approach. Try to use that in future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
This PR improves the input field labels used in the following dialogs:
Previously the dialog used a generic text input field without a clear label, which could make it unclear what users should enter.
This change adds contextual hints depending on the dialog type to improve clarity and user experience.
Fixes
Fixes #20475
Approach
The dialogs use a shared reusable layout
dialog_generic_text_input.xml.Instead of creating multiple layouts, the hint for the
TextInputLayoutis set dynamically inCreateDeckDialog.ktdepending on theDeckDialogType.The following hints are applied:
New string resources added:
deck_namesub_deck_namenew_deck_nameThis keeps the UI layout reusable while providing clearer input labels for each dialog.
How Has This Been Tested?
Tested locally by running the app and verifying the dialogs.
Steps:
Test environment:
Tested using a physical Android device and emulator
The existing validation and dialog behavior remain unchanged.
Learning (optional, can help others)
While working on this issue, I explored how reusable dialog layouts are implemented in the project and how
TextInputLayouthints can be updated dynamically depending on dialog context.Screenshots
Checklist
(https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor)