Skip to content

Remove right preview sidebar#182

Open
drebaglioni wants to merge 5 commits into
ankitvgupta:mainfrom
drebaglioni:drebaglioni/no-sidebar-upstream
Open

Remove right preview sidebar#182
drebaglioni wants to merge 5 commits into
ankitvgupta:mainfrom
drebaglioni:drebaglioni/no-sidebar-upstream

Conversation

@drebaglioni

@drebaglioni drebaglioni commented Jul 10, 2026

Copy link
Copy Markdown

Summary

  • remove the right EmailPreviewSidebar render path entirely
  • remove keyboard and command-palette entry points that could surface sidebar state
  • let ArrowUp/ArrowDown keep native scroll behavior instead of moving mail selection

Verification

  • npm run typecheck:web
  • npm run build
  • npx playwright test tests/e2e/sender-profile.spec.ts tests/e2e/sidebar-focused-email.spec.ts --project=e2e --workers=1
  • npx playwright test tests/e2e/arrow-key-navigation.spec.ts tests/e2e/keyboard-flow.spec.ts --project=e2e --workers=1

Release note

I attempted to publish v0.14.1 from the fork, but the release workflow failed at Apple signing because the fork has no Actions signing secrets (CSC_LINK / CSC_KEY_PASSWORD). The packaged updater points at the upstream repo, so this needs to land and be tagged from upstream to go live.


Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 1 additional finding in Devin Review.

Open in Devin Review

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Keyboard shortcut help dialog still advertises arrow keys for navigation after they were removed

The shortcuts help dialog still lists "j / ↓" and "k / ↑" as navigation keys (getKeyboardShortcuts at src/renderer/hooks/useKeyboardShortcuts.ts:1135-1136), but the arrow key handlers were removed from the keyboard event handler in this PR, so pressing ↓ or ↑ no longer navigates the email list.

Impact: Users who open the help dialog (?) will see arrow keys documented as working shortcuts, but pressing them does nothing for email navigation.

Stale help text after arrow key handler removal

The PR removed case "ArrowDown": and case "ArrowUp": from the switch statement in the keyboard handler (around lines 766-785), but the getKeyboardShortcuts() function at src/renderer/hooks/useKeyboardShortcuts.ts:1135-1136 still returns:

{ key: "j / ↓", description: "Move down" },
{ key: "k / ↑", description: "Move up" },

These should be updated to just "j" and "k" respectively. The ShortcutHelp component at src/renderer/components/ShortcutHelp.tsx:36 consumes this data and renders it in the help modal.

(Refers to lines 1135-1136)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@greptile-apps

greptile-apps Bot commented Jul 10, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes sidebar-driven mail preview behavior from the renderer. The main changes are:

  • Removed the right EmailPreviewSidebar render path from App.tsx.
  • Removed sidebar keyboard and command-palette entry points.
  • Changed ArrowUp and ArrowDown to preserve native scroll behavior.
  • Updated E2E tests to assert the preview sidebar stays hidden.

Confidence Score: 4/5

The agent-run path can still be opened, but its sidebar surface is no longer mounted.

  • The right preview sidebar removal is consistent with the PR goal.
  • ArrowUp and ArrowDown now fall through to native browser scrolling as intended.
  • The layout change also removes the agents sidebar while agent actions remain reachable.

src/renderer/App.tsx

Important Files Changed

Filename Overview
src/renderer/App.tsx Removes the right preview sidebar and also removes the mounted agents sidebar from the main layout.
src/renderer/hooks/useKeyboardShortcuts.ts Removes ArrowUp and ArrowDown from mail selection movement and removes the b sidebar shortcut.
src/renderer/components/CommandPalette.tsx Removes the command-palette action that opened the agents sidebar while keeping agent-run actions available.
src/renderer/components/KeyboardHints.tsx Removes the sidebar hint from the default keyboard hint bar.
tests/e2e/arrow-key-navigation.spec.ts Updates arrow-key tests to expect native scrolling behavior and no preview-sidebar reveal.
tests/e2e/keyboard-flow.spec.ts Updates keyboard-flow tests so ArrowUp and ArrowDown leave the selected email unchanged.
tests/e2e/sender-profile.spec.ts Updates sender-profile tests to verify the removed preview sidebar stays hidden.
tests/e2e/sidebar-focused-email.spec.ts Updates multi-sender thread coverage to assert the preview sidebar and sender sidebar fields remain hidden.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
src/renderer/App.tsx:2239
**Agent Sidebar Becomes Unreachable**

This removes the mounted `AgentsSidebar` along with the right preview sidebar, but the agent palette entry point still lets users start agent runs. When a user runs agents through the remaining command path, `isAgentsSidebarOpen` and `toggleAgentsSidebar()` no longer have any rendered consumer, so the workflow can start without the sidebar surface that shows its state or progress.

Reviews (1): Last reviewed commit: "Fix sender profile sidebar test import" | Re-trigger Greptile

Comment thread src/renderer/App.tsx
@@ -2242,9 +2239,6 @@ export default function App() {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Agent Sidebar Becomes Unreachable

This removes the mounted AgentsSidebar along with the right preview sidebar, but the agent palette entry point still lets users start agent runs. When a user runs agents through the remaining command path, isAgentsSidebarOpen and toggleAgentsSidebar() no longer have any rendered consumer, so the workflow can start without the sidebar surface that shows its state or progress.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/renderer/App.tsx
Line: 2239

Comment:
**Agent Sidebar Becomes Unreachable**

This removes the mounted `AgentsSidebar` along with the right preview sidebar, but the agent palette entry point still lets users start agent runs. When a user runs agents through the remaining command path, `isAgentsSidebarOpen` and `toggleAgentsSidebar()` no longer have any rendered consumer, so the workflow can start without the sidebar surface that shows its state or progress.

How can I resolve this? If you propose a fix, please make it concise.

@ankitvgupta

Copy link
Copy Markdown
Owner

why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants