Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix infinite loop when client handshake disconnects #73

Merged
merged 1 commit into from
Sep 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/client_connection.ml
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ let read t bs ~off ~len =

let read_eof t bs ~off ~len =
match t.state with
| Handshake handshake -> Client_handshake.read handshake bs ~off ~len
| Handshake handshake -> Client_handshake.read_eof handshake bs ~off ~len
| Websocket websocket -> Websocket_connection.read_eof websocket bs ~off ~len

let next_write_operation t =
Expand Down
3 changes: 3 additions & 0 deletions lib/client_handshake.ml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ let next_write_operation t =
let read t =
Httpun.Client_connection.read t.connection

let read_eof t =
Httpun.Client_connection.read_eof t.connection

let yield_reader t =
Httpun.Client_connection.yield_reader t.connection

Expand Down