Skip to content

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Sep 9, 2025

The Object IDs were not checked correctly in the RLs.

@lukaszcz lukaszcz requested a review from Copilot September 9, 2025 13:00
@lukaszcz lukaszcz self-assigned this Sep 9, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes resource logic functions by correcting how Object IDs are handled in Resource Logic (RL) functions. The main issue was that Object IDs were not being checked correctly in the validation logic.

  • Renamed SomeObjectData to ObjectValue and added a uid field to properly track object identifiers
  • Updated the Nonce structure to use value instead of nat for consistency
  • Modified resource validation logic to properly compare object UIDs with resource values

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
Anoma/Nonce.lean Renamed field from nat to value for consistency
AVM/Object.lean Replaced SomeObjectData with ObjectValue structure that includes uid field
AVM/Logic.lean Updated resource validation to properly check object UIDs against resource values
AVM/Class/Translation/Logics.lean Modified constructor, destructor, and method logic functions to use new validation approach

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lukaszcz lukaszcz merged commit ecb7af5 into main Sep 16, 2025
1 check passed
@lukaszcz lukaszcz deleted the fix-logics branch September 16, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants