-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-dependent default values to the new typechecking algorithm #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
changed the title
Add default values to the new typechecking algorithm
Add non-dependent default values to the new typechecking algorithm
Nov 16, 2023
janmasrovira
force-pushed
the
new-algorithm-default-values
branch
from
November 16, 2023 14:45
5a38e62
to
cd57475
Compare
janmasrovira
force-pushed
the
new-algorithm-default-values
branch
2 times, most recently
from
November 16, 2023 15:20
b60e25d
to
8a344e0
Compare
janmasrovira
force-pushed
the
new-algorithm-default-values
branch
from
November 21, 2023 13:49
5fc53e3
to
8bd5e13
Compare
paulcadman
force-pushed
the
new-algorithm-default-values
branch
from
November 21, 2023 15:20
8bd5e13
to
97f2c9a
Compare
paulcadman
approved these changes
Nov 22, 2023
paulcadman
force-pushed
the
new-algorithm-default-values
branch
from
November 23, 2023 09:24
d06686e
to
8bcf956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds default values (that don't depend on previous default values) under the new
--new-typechecker
flag.