-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve inference for --new-typechecker
#2524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
improve-inference
branch
4 times, most recently
from
November 23, 2023 10:43
f092769
to
68645d2
Compare
janmasrovira
changed the title
Improve inference
Improve inference for Nov 24, 2023
--new-typechecker
paulcadman
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested compilation of juvix-containers etc. with the new typechecker.
paulcadman
force-pushed
the
improve-inference
branch
from
November 28, 2023 14:25
1a73db6
to
9f4b30b
Compare
thanks! |
paulcadman
pushed a commit
that referenced
this pull request
Nov 28, 2023
Adds all existing negative tests for the new typechecker. - Depends on #2524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr applies a number of fixes to the new typechecker.
The fixes implemented are:
fun : _ := body
. This is a workaround to Bug in typechecking (inference generates ill-scoped terms) #2247 and Typechecking infers incorrect types #2517