Fix the global 'package' package so that modules within it can be type-checked independently #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Package loader PathResolver must the root of the project being loaded to the Package.juvix file. The order of clauses in the match changed by this commit must not be permuted because the global 'package' package now contains its own Package.juvix file. Previously a project's Package.juvix was incorrectly being assigned to the global project root.
janmasrovira
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Package.juvix file to the global 'package' package (that is the package containing the
PackageDescription.{Basic, V1}modules.This means that users can now go-to-definition on Package.juvix types and identifiers and navigate to fully highlighted
PackageDescription.{Basic, V1}modules.