-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract builtin definitions for loading a Package into bundled package-base package #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
package-base-split
branch
from
November 29, 2023 14:55
faabcbf
to
5409d9e
Compare
janmasrovira
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
PackageDescription.V1 continues to depend on Stdlib.Prelude to avoid breaking existing Package files that import Stdlib.Prelude.
paulcadman
force-pushed
the
package-base-split
branch
from
November 30, 2023 15:20
5b6a31c
to
73f0cb6
Compare
janmasrovira
pushed a commit
to anoma/juvix-stdlib
that referenced
this pull request
Dec 1, 2023
The package-base module was added in anoma/juvix#2535 - this PR updates the standard library to reused the contents of this package to avoid duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new package that's bundled with the compiler in a similar way to the stdlib and the package description package.
The
package-base
PackageThis package is called package-base and contains the minimal set of definitions required to load a Package file.
The
Juvix.Builtin
module contains:Juvix.Builtin.V1.Bool
is required to support backend primitive integersJuvix.Builtin.V1.Trait.Natural
is required to support numeric literals.The
PackageDescription.V2
moduleThis PR also adds a new
PackageDescription.V2
type that uses thepackage-base
. This is to avoid breaking existing Package files. The Packages files in the repo (except those that testPackageDescription.V1
) have also been updated.Updating the stdlib
The standard library will be updated to use
Juvix.Builtin.*
modules in a subsequent PR.