Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime Makefile: Do not resolve variables when writing a dependency file #2538

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

paulcadman
Copy link
Collaborator

This is an attempt to fix a confusing situation where a user:

  1. Builds the runtime with clang that does not support wasm32-wasi
  2. Attempts to rebuild the runtime by passing the CC parameter pointing to another installation of clang that does support wasm32-wasi.

In step 1. the runtime Makefile generates dependencies files which contain the resolved value of $(CC). When the user passes the correct CC variable to the Makefile in step 2., the dependencies files are not regenerated, the old value of CC is used in the build and the build continues to fail.

In this PR we change the dependency file generation so that the variables like $(CC) are written into the dependency file verbatim. They are resolved when they are run in step 2. using the new value of the CC parameter.

@paulcadman paulcadman self-assigned this Nov 24, 2023
@paulcadman paulcadman added this to the 0.5.5 milestone Nov 24, 2023
@lukaszcz lukaszcz merged commit d8027fc into main Nov 27, 2023
4 checks passed
@lukaszcz lukaszcz deleted the runtime-makefile-deps-change branch November 27, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants