runtime Makefile: Do not resolve variables when writing a dependency file #2538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix a confusing situation where a user:
In step 1. the runtime Makefile generates dependencies files which contain the resolved value of
$(CC)
. When the user passes the correctCC
variable to the Makefile in step 2., the dependencies files are not regenerated, the old value ofCC
is used in the build and the build continues to fail.In this PR we change the dependency file generation so that the variables like
$(CC)
are written into the dependency file verbatim. They are resolved when they are run in step 2. using the new value of the CC parameter.