Remove old typechecker #2545
Merged
Remove old typechecker #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
janmasrovira
commented
Nov 29, 2023
•
janmasrovira
commented
- Add dependent defaults for the new typechecker #2541
- Add new case for positivity checker: type cannot occur as arg of bound var #2542
lukaszcz
reviewed
Nov 30, 2023
test/Compilation/Positive.hs
Outdated
| ignored :: HashSet String | ||
| ignored = | ||
| HashSet.fromList | ||
| [ "Test046: Polymorphic type arguments", |
There was a problem hiding this comment.
Instead of ignoring this test with the new typechecker, we should modify it to work by inserting the implicit holes manually as required (in a minimal way).
There was a problem hiding this comment.
I've addressed it here a8eddc7.
jonaprieto
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.