Implement wildcard constructor #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
implement-wildcard-constructor
branch
from
f9702d5
to
65e9569
Compare
janmasrovira
force-pushed
the
implement-wildcard-constructor
branch
from
65e9569
to
692d1d9
Compare
paulcadman
approved these changes
Dec 6, 2023
janmasrovira
force-pushed
the
implement-wildcard-constructor
branch
from
accb3f2
to
fda68e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PatternWildcardConstructor#2549The implementation of wildcard constructors was previously done in the arity checker. I did not realise I was missing it because there was not tests for it that included typechecking (we were only checking formatting).