-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation of side conditions in pattern matches #2984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
force-pushed
the
matching-side-conditions
branch
3 times, most recently
from
September 3, 2024 17:22
b26f4a0
to
f904923
Compare
lukaszcz
force-pushed
the
matching-side-conditions
branch
from
September 5, 2024 09:21
08403ad
to
96947e8
Compare
lukaszcz
requested review from
janmasrovira and
paulcadman
and removed request for
janmasrovira
September 5, 2024 12:23
lukaszcz
force-pushed
the
matching-side-conditions
branch
2 times, most recently
from
September 6, 2024 12:32
e09511d
to
6596393
Compare
As discussed, let's first merge the removal of |
janmasrovira
force-pushed
the
matching-side-conditions
branch
from
September 8, 2024 10:00
6596393
to
649be19
Compare
janmasrovira
approved these changes
Sep 9, 2024
lukaszcz
force-pushed
the
matching-side-conditions
branch
from
September 9, 2024 08:33
649be19
to
9b6f05a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match
nodes in Core. Updates Core parsing, printing and the evaluator.else
branch are allowed in Core. If there is anelse
branch, the side conditions are translated infromInternal
into nested ifs. Because withelse
the conditions are exhaustive, there are no implications for pattern exhaustiveness checking.