Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not inline the functions library everywhere in the Nockma backend #3004

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Do not inline the functions library everywhere in the Nockma backend #3004

merged 1 commit into from
Sep 8, 2024

Conversation

janmasrovira
Copy link
Collaborator

No description provided.

@janmasrovira janmasrovira marked this pull request as ready for review September 8, 2024 17:14
lukaszcz
lukaszcz approved these changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@lukaszcz lukaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In addition to the functions library, it seems we're also inlining the standard library in every closure (StandardLibrary -> OpQuote # stdlib in goAllocClosure). We should abstract this out as the next step.

@lukaszcz lukaszcz merged commit 453afff into main Sep 8, 2024
8 checks passed
@lukaszcz lukaszcz deleted the remove-huge-nockma-duplication branch September 8, 2024 20:39
@lukaszcz lukaszcz added this to the 0.6.7 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszcz lukaszcz lukaszcz approved these changes

Assignees

@paulcadman paulcadman

@janmasrovira janmasrovira

Labels
backend:nockma
Projects
None yet
Milestone
0.6.7
Development

Successfully merging this pull request may close these issues.
3 participants
@janmasrovira @lukaszcz @paulcadman