Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linux static build: Remove -j argument from C runtime make invocation #3055

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

paulcadman
Copy link
Collaborator

This PR removes the -j (concurrent jobs) argument from the C runtime make invocation.

-j cannot be used in the juvix_c make invocation because it causes an error in the 'Build Linux static binary workflow'

cd runtime && make
make[1]: Entering directory '/__w/juvix/juvix/runtime'
cd c && make -j 4 -s
make[3]: *** No rule to make target '_build.wasm32-wasi/src/juvix/arch/wasi.o', needed by 'all'.  Stop.
make[3]: *** No rule to make target '_build.wasm32-wasi-debug/src/juvix/arch/wasi.o', needed by 'all'.  Stop.
make[2]: *** [Makefile:20: wasm32-wasi] Error 2
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:35: wasm32-wasi-debug] Error 2
_build.native64/src/juvix/opts.d:1: *** recipe commences before first target.  Stop.
make[2]: *** [Makefile:26: native64] Error 2
_build.native64-debug/src/juvix/opts.d:1: *** recipe commences before first target.  Stop.
make[2]: *** [Makefile:41: native64-debug] Error 2
make[1]: *** [Makefile:9: juvix_c] Error 2
make[1]: Leaving directory '/__w/juvix/juvix/runtime'
make: *** [Makefile:206: runtime] Error 2

@paulcadman paulcadman added this to the 0.6.7 milestone Sep 20, 2024
@paulcadman paulcadman self-assigned this Sep 20, 2024
`-j` cannot be used in the juvix_c make invocation because it causes
an error in the 'Build Linux static binary workflow'

```
cd runtime && make
make[1]: Entering directory '/__w/juvix/juvix/runtime'
cd c && make -j 4 -s
make[3]: *** No rule to make target '_build.wasm32-wasi/src/juvix/arch/wasi.o', needed by 'all'.  Stop.
make[3]: *** No rule to make target '_build.wasm32-wasi-debug/src/juvix/arch/wasi.o', needed by 'all'.  Stop.
make[2]: *** [Makefile:20: wasm32-wasi] Error 2
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:35: wasm32-wasi-debug] Error 2
_build.native64/src/juvix/opts.d:1: *** recipe commences before first target.  Stop.
make[2]: *** [Makefile:26: native64] Error 2
_build.native64-debug/src/juvix/opts.d:1: *** recipe commences before first target.  Stop.
make[2]: *** [Makefile:41: native64-debug] Error 2
make[1]: *** [Makefile:9: juvix_c] Error 2
make[1]: Leaving directory '/__w/juvix/juvix/runtime'
make: *** [Makefile:206: runtime] Error 2
```
@lukaszcz lukaszcz merged commit 49e8c9d into main Sep 23, 2024
4 checks passed
@lukaszcz lukaszcz deleted the fix-linux-static-build-ci branch September 23, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants