Improve Set and Map modules in the standard library #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
requested review from
paulcadman and
janmasrovira
and removed request for
paulcadman
lukaszcz
force-pushed
the
improve-stdlib
branch
2 times, most recently
from
f870016
to
8774948
Compare
janmasrovira
previously approved these changes
Oct 24, 2024
|
I'll update stdlib submodule to main before we merge this. |
paulcadman
approved these changes
Oct 24, 2024
paulcadman
force-pushed
the
improve-stdlib
branch
from
d37c86b
to
203e7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nulltoisEmpty, which required updating some tests