Add anoma nockma tests #3134
Merged
Add anoma nockma tests #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
anoma-node-tests
branch
2 times, most recently
from
542337d
to
b785900
Compare
janmasrovira
force-pushed
the
anoma-node-tests
branch
9 times, most recently
from
1eda2e1
to
34275a5
Compare
paulcadman
force-pushed
the
anoma-node-tests
branch
from
34275a5
to
97ebd2b
Compare
paulcadman
force-pushed
the
anoma-node-tests
branch
from
97ebd2b
to
f803707
Compare
janmasrovira
force-pushed
the
anoma-node-tests
branch
3 times, most recently
from
56d35bd
to
7241408
Compare
This reverts commit 3b28dbd.
* Closes #2968 * Implements detection of function-like definitions, which either: - have some arguments on the left of `:`, or - have at least one clause. * Only function-like definitions are recursive. * Non-recursive definitions are not mutually recursive either, and can be used only after their definition. This necessitates rearranging some definitions in existing Juvix code. * Changes the scoping of identifiers in record updates. Now field names on the right side don't refer to the old values of the record fields but to identifiers in scope defined outside the record update. To refer to old values, one needs to explicitly use record projections, e.g. ``` r@Rec{x := Rec.x r} ```
janmasrovira
force-pushed
the
anoma-node-tests
branch
from
7241408
to
acb2e95
Compare
paulcadman
reviewed
Nov 5, 2024
paulcadman
reviewed
Nov 5, 2024
The argsPath in stdlib call should be unconditionally [R, L] i.e the 'arguments' slot of the stdlib function.
paulcadman
previously approved these changes
Nov 5, 2024
lukaszcz
reviewed
Nov 5, 2024
| | -- | The anoma node returns a response with an error | ||
| ClassNodeError | ||
| | -- | The anoma node returns a value but it doesn't match the expected value | ||
| ClassWrong |
There was a problem hiding this comment.
I think we don't need this one anymore
There was a problem hiding this comment.
Maybe we keep this for now as some of the ClassNodeError and ClassTrace may become ClassWrong once we're able to run them.
paulcadman
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've classified the tests in 4 categories:
Working. The test works as expected.Trace. We need more work on our end to get the traces from the anoma node and check that they match the expected result.NodeError. The anoma node returnsfailed to prove the nock program.Wrong. The anoma node returns some value that does not match the expected value.