Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adding Feature update balance when having new block #707

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kyrtill6b
Copy link

@kyrtill6b kyrtill6b commented Apr 1, 2024

Issue:

Solution

  • Using library from Cosmos to config websocket catch event of new block change.
  • Depend on the event, trigger the function reload balance for transparent account and save it into redux.
  • Block time is more than 10 second. It mean each 10s will be updated balance.

@kyrtill6b
Copy link
Author

Hi @mateuszjasiuk @emccorson, Could you please take a moment to look at my PR. Thanks in advance.

@emccorson
Copy link
Collaborator

Thank you for your contribution.

I haven't reviewed this yet, but I would say at first glance there are a few problems to overcome before this PR can be merged. Firstly, we need to decide whether the issue reported in #706 is something we want to support. Also, we are currently overhauling the interface, so a lot of code is already in the process of changing, including replacing redux with jotai.

For now, I think this PR can stay as a prototype solution for #706 if we decide to support this.

@emccorson emccorson added the needs discussion in issue Issue needs to be discussed before PR can be reviewed label Apr 3, 2024
@neopinhuy
Copy link

Hmm, I think this is a necessary feature because almost every wallet like Metamask, Kelpr, or Leap has it. The purpose of this is to provide convenience, transparency, and avoid minor errors. It's all about user experience, and I believe it's essential. Thank you for your contribution to it.
@kyrtill6b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion in issue Issue needs to be discussed before PR can be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants