Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CosmicValidator pre-genesis transactions #10

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

harish551
Copy link
Contributor

@harish551 harish551 commented Aug 21, 2024

Discord handler

harish0x12

Checklist before opening a pull request

  • My submissions follow the instructions
  • Im aware my submission will not be modifiable/delatable if merged

Copy link
Collaborator

@iskay iskay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the toml itself looks good, however the filename (CosmicValidator) needs to match your github name (harish551). can you either resubmit from CosmicValidator github account or change the filename? sorry, it's required by our CI checks for sybil reasons. Thanks!

@harish551
Copy link
Contributor Author

the toml itself looks good, however the filename (CosmicValidator) needs to match your github name (harish551). can you either resubmit from CosmicValidator github account or change the filename? sorry, it's required by our CI checks for sybil reasons. Thanks!

I thought it should match with github account which we are submitting PR

@harish551 harish551 requested a review from iskay August 21, 2024 19:32
@iskay
Copy link
Collaborator

iskay commented Aug 21, 2024

I think it needs to match the username of the user submitting the PR, @Fraccaman can correct me if I'm wrong here. Thanks for renaming, it's still failing but I think only due to a separate ci issue we need to resolve on our end

@iskay
Copy link
Collaborator

iskay commented Aug 21, 2024

One last thing -- there was a glitch with the CI on our end which is why the checks are failing still. We've pushed a fix; can you please rebase to latest and see if the checks pass now?

@harish551
Copy link
Contributor Author

One last thing -- there was a glitch with the CI on our end which is why the checks are failing still. We've pushed a fix; can you please rebase to latest and see if the checks pass now?

Done, can you approve once ?

@Fraccaman Fraccaman added this pull request to the merge queue Aug 22, 2024
Merged via the queue into anoma:main with commit d8669f1 Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants