Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Encapsulate (fka KingSuper) bond stage 2 #163

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

aditya-manit
Copy link
Contributor

Discord handler

kingsuper

Checklist before opening a pull request

  • My submissions follow the instructions
  • Im aware my submission will not be modifiable/delatable if merged

@Fraccaman
Copy link
Member

tpknam1qzluhwmzp9aek7hpvj8a2q8afacw4gcjs5g457cjq4l5sfuqj8dd2w26hqw is not part of balances.toml, just for info

@aditya-manit
Copy link
Contributor Author

aditya-manit commented Aug 29, 2024

tpknam1qzluhwmzp9aek7hpvj8a2q8afacw4gcjs5g457cjq4l5sfuqj8dd2w26hqw is not part of balances.toml, just for info

It is the public key for tnam1qpz93yrdr7d8g773lxj4h53c27kudz3ddvl9yd46 which is present in balances.toml

Let me know please if that wont work ?

@Fraccaman
Copy link
Member

I dont think tpknam1qzluhwmzp9aek7hpvj8a2q8afacw4gcjs5g457cjq4l5sfuqj8dd2w26hqw is part of balances.toml?

@aditya-manit
Copy link
Contributor Author

tpknam1qzluhwmzp9aek7hpvj8a2q8afacw4gcjs5g457cjq4l5sfuqj8dd2w26hqw

Yes its not, but balances.toml have transparent addresses (tnam1) not Public keys (tpknam1)

The transparent address for tpknam1qzluhwmzp9aek7hpvj8a2q8afacw4gcjs5g457cjq4l5sfuqj8dd2w26hqw is tnam1qpz93yrdr7d8g773lxj4h53c27kudz3ddvl9yd46 and it is present

@aditya-manit
Copy link
Contributor Author

Should I be using tnam1qpz93yrdr7d8g773lxj4h53c27kudz3ddvl9yd46 instead of tpknam1qzluhwmzp9aek7hpvj8a2q8afacw4gcjs5g457cjq4l5sfuqj8dd2w26hqw in source field ?

[[bond]]
source = "tpknam1qzluhwmzp9aek7hpvj8a2q8afacw4gcjs5g457cjq4l5sfuqj8dd2w26hqw"
validator = "tnam1q985emxj29hpz3dlye0yfe5hm66pmwqalu0y06p4"
amount = "84180"

@Fraccaman
Copy link
Member

okay so can use your tpknam address, but pls rename the file using as alias the github username of the forked repo (i.e encapsulate-xyz)

@aditya-manit
Copy link
Contributor Author

okay so can use your tpknam address, but pls rename the file using as alias the github username of the forked repo (i.e encapsulate-xyz)

ah sorry about that, I thought it was the username of the account who is raising the PR

Just made the changes, and have opened the PR for review as well, thanks

@aditya-manit aditya-manit marked this pull request as ready for review September 20, 2024 16:01
@iskay iskay added this pull request to the merge queue Sep 23, 2024
Merged via the queue into anoma:main with commit ecb8a47 Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants