Skip to content

style: silence linter warning #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

style: silence linter warning #32

merged 1 commit into from
Jul 3, 2025

Conversation

heueristik
Copy link
Collaborator

@heueristik heueristik commented Jul 3, 2025 •
edited
Loading

See https://github.com/anoma/token/actions/runs/16049356137/job/45288084213?pr=27#step:13:10

Explanation:

a >= b costs slightly more gas than a+1 > b

a+1 overflowing is not a concern here

@heueristik heueristik requested a review from agureev July 3, 2025 14:55
@heueristik heueristik changed the title style: fix linter warning style: silence linter warning Jul 3, 2025
@heueristik heueristik added this to the Audit 1 milestone Jul 3, 2025
agureev
agureev approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@agureev agureev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve modulo the fact that we may want supply > 1 billion to represent decimal values.

@heueristik heueristik merged commit 1abfa66 into main Jul 3, 2025
1 check passed
@heueristik heueristik deleted the feature/satisfy-linter branch July 3, 2025 15:11
@heueristik heueristik self-assigned this Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agureev agureev agureev approved these changes

Assignees

@heueristik heueristik

Labels
None yet
Projects
None yet
Milestone
Audit 1
Development

Successfully merging this pull request may close these issues.
2 participants
@heueristik @agureev