app: keybinds match the produced character, so Ctrl+F and other letter shortcuts fail on non-Latin layouts #55676

Activity

1. opencode-agent commented on Oct 15, 2026

   

   opencode-agentBot

   on Oct 15, 2026 – with OpenCode Agent

   Contributor

   More actions

   Thanks for the detailed report. I can confirm this.

   I couldn't run the Windows desktop app here, so I tested the app's own keybind matcher (matchKeybind / parseKeybind in packages/app/src/shell/commands/command.tsx) with the keyboard events a Russian layout produces:

   • Ctrl+F on the US layout (key: "f", code: "KeyF") matches mod+f.
   • Ctrl+F on the Russian layout (key: "а", code: "KeyF") does not match.
   • The same goes for mod+p, mod+t, mod+w, mod+comma, mod+. and mod+[.
   • Alt+F on the Russian layout does match, through the existing event.code fallback.

   The results are the same on 2.0.29 and on the latest dev (4397ee44). The test script below reproduces it.

   Related: #40048 (same problem on v1, closed by the stale bot), plus the open PRs #54573 and #54708, which change the same function for other keyboard cases.

   Reproduction script (layout-keybind.test.ts)

   // Reproduces anomalyco/opencode#55676 against the app's real keybind matcher.
   // Usage (from a checkout of anomalyco/opencode, after `bun install`):
   //   cp layout-keybind.test.ts packages/app/src/shell/commands/
   //   cd packages/app && bun test src/shell/commands/layout-keybind.test.ts
   // Non-mac platform is assumed (bun has no navigator.platform => "mod" = ctrl).
   import { expect, test } from "bun:test"
   import { matchKeybind, parseKeybind } from "./command"
   
   // Minimal KeyboardEvent shape as Chromium/WebView2 delivers it on Windows.
   function ev(key: string, code: string, mods: { ctrl?: boolean; shift?: boolean; alt?: boolean; meta?: boolean } = {}) {
     return {
       key,
       code,
       ctrlKey: !!mods.ctrl,
       shiftKey: !!mods.shift,
       altKey: !!mods.alt,
       metaKey: !!mods.meta,
     } as KeyboardEvent
   }
   
   // Physical key -> [US layout key, Russian ЙЦУКЕН layout key]
   const cases: Array<[string, string, string, string]> = [
     // keybind, code, en key, ru key
     ["mod+f", "KeyF", "f", "а"], // session.search (find bar)
     ["mod+p", "KeyP", "p", "з"],
     ["mod+t", "KeyT", "t", "е"],
     ["mod+w", "KeyW", "w", "ц"],
     ["mod+comma", "Comma", ",", "б"],
     ["mod+.", "Period", ".", "ю"],
     ["mod+[", "BracketLeft", "[", "х"],
   ]
   
   for (const [bind, code, en, ru] of cases) {
     test(`${bind} on US layout (key=${en})`, () => {
       expect(matchKeybind(parseKeybind(bind), ev(en, code, { ctrl: true }))).toBe(true)
     })
     test(`${bind} on Russian layout, same physical key (key=${ru}, code=${code})`, () => {
       expect(matchKeybind(parseKeybind(bind), ev(ru, code, { ctrl: true }))).toBe(true)
     })
   }
   
   // Control: the event.code fallback already works when Alt is held.
   test("alt+f on Russian layout (key=а, code=KeyF) matches via code fallback", () => {
     expect(matchKeybind(parseKeybind("alt+f"), ev("а", "KeyF", { alt: true }))).toBe(true)
   })

   Run it: bun layout-keybind.test.ts
2. opencode-agent

   added

   reproduced

   on Oct 15, 2026
3. ZXLyyds100 commented on Oct 15, 2026

   

   ZXLyyds100

   on Oct 15, 2026

   Last edited by ZXLyyds100

   More actions

   I'd like to take this on. I'll cover Ctrl/Meta shortcuts whose key is a non-Latin character, including punctuation keys, while preserving Latin layout mappings and unmodified custom bindings. I'll extend the existing command matcher tests. I've checked #54573 and #54708; their Option and Dead/Unidentified cases are separate from this fix.

   Delivery update, October 29: #55765 at 4f0cf1cb98d3c8abded6e5497dcbee010f447f96 now normally merges current dev@726cf096, preserving recording, bracket/Option behavior and the new declined-command contract. This is AI-assisted implementation/testing/self-review, not independent human review.

   Local verification: 63 focused command tests, 630 randomized repetitions, 971 unit + 251 browser tests, 20 focused Chrome component repetitions, app TypeScript, root check/normal push hook, changed-file lint and formatting passed. Current upstream first fails 13 command assertions and both focused browser regressions.

   The PR describes the remaining baseline browser failures honestly: full components 205 passed / 2 failed; the selected built-mode keepers 3 passed / 4 failed, also reproduced on the same upstream production code. No assertions were skipped or weakened. Synthetic keyboard events on macOS/Chrome are not OS-level Russian-layout or hosted Linux/Windows verification. Maintainer review and fork-workflow approval are still separate gates.
4. ZXLyyds100

   added a commit that references this issue on Oct 15, 2026

   fix(app): match shortcuts on non-Latin keyboard layouts

   ...

   This issue will close once commit 35d45ac is merged into the 'dev' branch.

   35d45ac