Skip to content

chore(opencode): remove dead patch and acp code - #59670

Open
rekram1-node wants to merge 1 commit into
v1from
v1-remove-dead-patch-acp
Open

rekram1-node wants to merge 1 commit into
v1from
v1-remove-dead-patch-acp

Conversation

@rekram1-node

Copy link
Copy Markdown
Contributor

Problem

A few things in packages/opencode/src aren't used anywhere anymore. I grepped the whole repo, tests included, and nothing references them.

Change

Delete only. No behavior changes.

 src/patch/index.ts
-  maybeParseApplyPatchVerified
-  MaybeApplyPatchVerified, ApplyPatchAction, ApplyPatchFileChange, ApplyPatchError
-  unused `path` import
 src/acp/tool.ts
-  10 legacy alias exports (mapToolKind, buildPendingToolCall, ...)
 src/acp/usage.ts
-  SDK, messageLoaderFromSDK, messageLoaderLayer
 src/tool/tool.ts
-  DynamicDescription + its TODO

Out of scope

maybeParseApplyPatch and MaybeApplyPatch stay since the patch tests still use them.

Verification

  • bun typecheck in packages/opencode passes
  • bun test test/patch test/acp in packages/opencode: 178 pass, 0 fail

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants