Repository navigation
remove unused exports and imports - #59673
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A few exports in
packages/opencode/srchave no callers anywhere in the repo, and a bunch of files carry imports they never use.Change
Cleanup only, no behavior change.
ReleaseTypeandRepositoryErrorwere only used by the removed functions. I grepped the whole repo for each name first.For unused imports I only removed two kinds, since
verbatimModuleSyntaxkeeps value imports at runtime:import type { X }with no useOut of scope
The whole value imports (for example
MessageV2insession/retry.ts,SessionV2insession/session.ts) are left alone.patch/,acp/andtool/tool.tsare untouched.Verification
bun typecheckinpackages/opencodepassesbun test test/tool/glob.test.ts test/tool/grep.test.ts test/tool/write.test.ts test/agent/agent.test.tsinpackages/opencode: 66 pass