Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/tui/src/mini/runtime.queue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ export async function runPromptQueue(input: QueueInput): Promise<void> {
if (next.type === "error") {
throw next.error
}
admission.resolve()
if (sent.mode !== "shell" && admissionVersion !== version) {
do {
const current = admissionVersion
Expand Down
39 changes: 39 additions & 0 deletions packages/tui/test/mini/runtime.queue.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,45 @@ describe("run runtime queue", () => {
expect(admitted).toEqual(["three"])
})

test.each([false, true])(
"releases follow-ups after a handled prompt failure (admission fails: %s)",
async (fails) => {
const ui = createFooterApiFixture()
const started = Promise.withResolvers<void>()
const request = Promise.withResolvers<void>()
const admitted: string[] = []
const errors: string[] = []
const task = runPromptQueue({
footer: ui.api,
run: async () => {
started.resolve()
// The interactive runtime displays transport errors and returns without admission.
await request.promise.catch((error: Error) => {
errors.push(error.message)
})
},
admit: async (prompt) => {
admitted.push(prompt.text)
if (fails) throw new Error("follow-up failed")
},
onAdmissionError: (_prompt, error) => {
errors.push(error instanceof Error ? error.message : String(error))
},
settle: async () => ui.api.close(),
})

ui.submit("one")
await started.promise
ui.submit("two")
request.reject(new Error("transport failed"))
await task

expect(admitted).toEqual(["two"])
expect(errors).toEqual(fails ? ["transport failed", "follow-up failed"] : ["transport failed"])
expect(ui.api.isClosed).toBe(true)
},
)

test("close aborts an in-flight durable admission", async () => {
const ui = createFooterApiFixture()
let admissionHit = false
Expand Down
Loading