Skip to content

fix(gui-plugins): support insecure file picker #59860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aeromtrich wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(gui-plugins): support insecure file picker #59860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/app/e2e/regression/review.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,21 @@ test("a rejected Git init releases its session's button without showing an error
await expect(init).toBeEnabled()
})

test("opens the file picker when randomUUID is unavailable", async ({ page }) => {
await page.addInitScript(() => {
// SAFETY: a non-localhost HTTP origin exposes crypto but not crypto.randomUUID.
Object.defineProperty(globalThis.crypto, "randomUUID", { configurable: true, value: undefined })
})

await openSession(page, { name: "ReviewOpenFileInsecure" })
await page.getByRole("button", { name: "Toggle review" }).click()

const panel = page.locator("#review-panel")
await openFileLauncher(panel)
await expect(panel.getByRole("tab", { name: "Open file", exact: true })).toHaveAttribute("aria-selected", "true")
await expect(panel.getByRole("combobox", { name: "Filter files" })).toBeVisible()
})

test("open file tab browses, searches, and tracks missing files", async ({ page }) => {
const searches: { query: string; dirs?: string; limit?: number; directory: string }[] = []
const directory = "C:/OpenCode/ReviewOpenFile"
Expand Down
5 changes: 4 additions & 1 deletion packages/gui-plugins/src/file/renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,10 @@ const setup: Plugin.Setup<typeof File> = (ctx) => {

if (selected || layout.narrow())
layout.open(`file:${selected ?? OPEN}`, session, { tab: "preview", background: options?.background })
else layout.open(`file:${OPEN}:${crypto.randomUUID()}`, session, { tab: "select" })
else
layout.open(`file:${OPEN}:${crypto.randomUUID?.() ?? Math.random().toString(16).slice(2)}`, session, {
tab: "select",
})

if (!options?.background && layout.narrow() && !layout.side.opened(session)) layout.side.toggle(session)
})
Expand Down
Loading