Skip to content

Conversation

@rekram1-node
Copy link
Collaborator

@rekram1-node rekram1-node commented Jan 7, 2026

closes: #7168
closes: #4560

Combines ideas from:
#6234 by @ben-vargas
#6048 by @shantur

@rekram1-node rekram1-node marked this pull request as draft January 7, 2026 18:16
@rekram1-node
Copy link
Collaborator Author

/review

@rekram1-node
Copy link
Collaborator Author

/review

@rekram1-node
Copy link
Collaborator Author

/review

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

lgtm

@rekram1-node rekram1-node marked this pull request as ready for review January 7, 2026 22:28
@rekram1-node
Copy link
Collaborator Author

/review

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Overall the PR looks good! The main suggestion is a minor style preference:

  • The else if/else chain in read.ts (line 130-134) could potentially use early returns, but the current code is readable and this is not a violation per se.

The code follows good practices, uses Bun APIs appropriately, and the implementation is solid. The let statements used are appropriate for loop contexts.

@rekram1-node
Copy link
Collaborator Author

/review

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

lgtm

@rekram1-node rekram1-node merged commit 1b82511 into dev Jan 7, 2026
3 checks passed
paralin added a commit to paralin/opencode that referenced this pull request Jan 11, 2026
fixup! feat: write truncated tool outputs to files (anomalyco#7239)

Add truncated: false to image and PDF returns to fix type inference.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to paralin/opencode that referenced this pull request Jan 12, 2026
fixup! feat: write truncated tool outputs to files (anomalyco#7239)

Add truncated: false to image and PDF returns to fix type inference.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to paralin/opencode that referenced this pull request Jan 13, 2026
fixup! feat: write truncated tool outputs to files (anomalyco#7239)

Add truncated: false to image and PDF returns to fix type inference.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to paralin/opencode that referenced this pull request Jan 13, 2026
fixup! feat: write truncated tool outputs to files (anomalyco#7239)

Add truncated: false to image and PDF returns to fix type inference.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to paralin/opencode that referenced this pull request Jan 13, 2026
fixup! feat: write truncated tool outputs to files (anomalyco#7239)

Add truncated: false to image and PDF returns to fix type inference.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to paralin/opencode that referenced this pull request Jan 15, 2026
fixup! feat: write truncated tool outputs to files (anomalyco#7239)

Add truncated: false to image and PDF returns to fix type inference.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to paralin/opencode that referenced this pull request Jan 16, 2026
fixup! feat: write truncated tool outputs to files (anomalyco#7239)

Add truncated: false to image and PDF returns to fix type inference.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add Fetch tool that saves to file (like Claude Code) [FEATURE]: Context protection for tool calls when response is large

2 participants