fix(state): delete key from recordsByKey on instance disposal

[sauerdaniel]

Summary

Fix memory leak in State.dispose() where disposed instance keys remain in the parent Map forever.

Fixes #4315
Relates to #3013

Problem

The State namespace uses a two-level Map structure:

• recordsByKey: Map<string, Map<any, Entry>> - outer Map keyed by instance
• Inner Map stores state entries for that instance

When State.dispose(key) is called:

1. It gets the entries Map for the key
2. Calls dispose on each entry
3. Calls entries.clear() to empty the inner Map
4. Bug: Never deletes the key from recordsByKey

This means every disposed instance leaves an empty Map<any, Entry> in recordsByKey, causing unbounded memory growth over the application lifetime.

Solution

Add recordsByKey.delete(key) after entries.clear() to remove the outer Map entry entirely.

entries.clear()
recordsByKey.delete(key)  // <-- Added
await Promise.all(tasks)

Testing

• ✅ Build passes for all platforms
• ✅ Full test suite passes (652 tests, 0 failures)
• Code-review verified to follow correct cleanup pattern

[github-actions]

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

1. Open an issue describing the bug/feature (if one doesn't exist)
2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found related PRs addressing memory leak issues in disposal patterns, but they appear to focus on different areas:

Potentially Related PRs:

1. fix(core): add dispose functions to prevent subscription memory leaks #7032 - fix(core): add dispose functions to prevent subscription memory leaks

   • fix(core): add dispose functions to prevent subscription memory leaks #7032
   • Related pattern of adding dispose cleanup logic to prevent memory leaks

2. fix(core): add dispose functions to prevent subscription memory leaks #7914 - fix(core): add dispose functions to prevent subscription memory leaks

   • fix(core): add dispose functions to prevent subscription memory leaks #7914
   • Same title as fix(core): add dispose functions to prevent subscription memory leaks #7032, likely related memory leak prevention in core

3. fix: clean up pending permissions when session is deleted #7154 - fix: clean up pending permissions when session is deleted

   • fix: clean up pending permissions when session is deleted #7154
   • Related cleanup pattern when objects are deleted/disposed

These PRs address similar memory leak patterns in disposal/cleanup scenarios, but none appear to be direct duplicates of PR #8252. PR #8252 is specifically fixing the State.dispose() memory leak by deleting keys from recordsByKey, while the related PRs focus on subscription cleanup and session cleanup in different areas of the codebase.

[sauerdaniel]

Duplicate Analysis

The bot mentioned PRs #7032, #7914, and #7154 as potentially related. After investigation:

PR	Files Modified	Focus
#7032	agent.ts, bus/index.ts, format/index.ts, plugin/index.ts, share-next.ts, share.ts	Bus subscription cleanup via dispose() functions
#7914	Same as #7032 (rebased version)	Same - Bus subscription cleanup
#7154	permission/next.ts	Pending permission cleanup on session delete
#8252	state.ts	Map entry cleanup in State.dispose()

Verdict: Not a duplicate.

This PR fixes a different memory leak pattern in a completely different file. The State namespace maintains a recordsByKey Map that tracks state entries per project root. The existing dispose() function calls entries.clear() but never removes the root Map entry itself, causing unbounded growth over time.

The other PRs focus on Bus subscription cleanup and permission cleanup - none touch state.ts or address the Map entry retention issue fixed here.

[rekram1-node]

/review

[github-actions]

lgtm

[rekram1-node]

@sauerdaniel thank you for finding these tiny details, they are hard to catch and great finds!!!

very very much appreciated and I bet youll find more.

please ping me if I miss ur prs because ur prs so far are better than most relating to mem/resource issues

[sauerdaniel]

@rekram1-node thank you very much, AI helps a lot :)