perf(utf8): optimize wrap breaks #507
Merged
+17
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored `findWrapBreaks` to remove data dependencies. The old implementation chained `@select` calls serially. The new one uses bitwise ORs on boolean vectors, allowing the CPU to check all character classes (whitespace, punctuation, brackets) in parallel instructions.
simonklee
force-pushed
the
perf-utf8-simd-parallel
branch
from
7093376 to
a002273
Compare
Collaborator
|
I assume you've run your local bench comparison. Would be awesome to get that into the pipeline. |
Contributor
Author
Yeh, sorry. I forgot to add it to the PR description. I didn't really find this one in a benchmark, it just caught my eye when going through adjacent code for #506 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
findWrapBreaksto remove data dependencies. The old implementation chained@selectcalls serially. The new one uses bitwise ORs on boolean vectors, allowing the CPU to check all character classes (whitespace, punctuation, brackets) in parallel instructions.