Skip to content

feat: add base path support to TanStack Start #6279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andremonteiro95 wants to merge 1 commit into
base: dev
Choose a base branch
from
+25 −9
Open

feat: add base path support to TanStack Start #6279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions platform/src/components/aws/tan-stack-start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,24 @@ export interface TanStackStartArgs extends SsrSiteArgs {
* }
* }
* ```
*
* Finally, to serve your TanStack Start app **from a combined pattern** like
* `dev.example.com/docs`, you'll need to configure the domain in your `Router` to
* match the subdomain, and set the `domain` and the `path`.
*
* ```ts {4,5}
* {
* router: {
* instance: router,
* domain: "dev.example.com",
* path: "/docs"
* }
* }
* ```
*
* Also, make sure to set this as the `base` in your `vite.config.ts`, and in your Nitro plugin config.
*/
router?: Prettify<Omit<RouterRouteArgs, "path">>;
router?: SsrSiteArgs["router"];
/**
* The command used internally to build your TanStack Start app.
*
Expand Down Expand Up @@ -375,14 +391,14 @@ export class TanStackStart extends SsrSite {
// If basepath is configured, nitro.mjs will have a line that looks like this:
// return createRouter$2({ routeTree: Nr, defaultPreload: "intent", defaultErrorComponent: ce, defaultNotFoundComponent: () => jsx(de, {}), scrollRestoration: true, basepath: "/tan" });
let basepath;
// TanStack Start currently doesn't support basepaths.
//try {
// const serverNitroChunk = fs.readFileSync(
// path.join(serverOutputPath, "chunks", "nitro", "nitro.mjs"),
// "utf-8",
// );
// basepath = serverNitroChunk.match(/basepath: "(.*)"/)?.[1];
//} catch (e) {}

try {
const serverNitroChunk = fs.readFileSync(
path.join(serverOutputPath, "chunks", "_", "server.mjs"),
"utf-8",
);
basepath = serverNitroChunk.match(/ROUTER_BASEPATH = "(.*)"/)?.[1];
} catch (e) {}

// Remove the .output/public/_server directory from the assets
// b/c all `_server` requests should go to the server function. If this folder is
Expand Down