Skip to content

fix(runtime): prevent goroutine leak and panic in node worker logs #6294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuaokolo wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(runtime): prevent goroutine leak and panic in node worker logs #6294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions pkg/runtime/node/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,18 +95,31 @@ func (w *Worker) Logs() io.ReadCloser {

var wg sync.WaitGroup
wg.Add(2)
go func() {
defer wg.Done()
_, _ = io.Copy(writer, w.stdout)
}()
go func() {

copyStream := func(dst io.Writer, src io.Reader) {
defer wg.Done()
_, _ = io.Copy(writer, w.stderr)
}()
buf := make([]byte, 32*1024)
for {
nr, err := src.Read(buf)
if nr > 0 {
nw, werr := dst.Write(buf[0:nr])
if werr != nil || nw != nr {
return
}
}
if err != nil {
// Pipe closed or process died, stop copying
return
}
}
}

go copyStream(writer, w.stdout)
go copyStream(writer, w.stderr)

go func() {
wg.Wait()
defer writer.Close()
writer.Close()
}()

return reader
Expand Down