-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add routes option to cloudflare.Worker
#6744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Makisuo
wants to merge
4
commits into
anomalyco:dev
Choose a base branch
from
Makisuo:add-cloudflare-worker-routes
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b7f0e52
Add `routes` option to `cloudflare.Worker`
Makisuo 695da95
Allow `WorkersRoute` in component physical-name validation
Makisuo dc57cff
Update platform/src/components/cloudflare/worker.ts
Makisuo fd84aea
Refactor `createWorkersRoutes` to avoid Pulumi resource-in-apply leak
Makisuo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as i'm learning more about this routes feature, i'm thinking whether it's a good idea to automatically create the DNS record for the user
if we don't, probably we should add an example of how to do it. ideally, we would create it, but i guess if you have multiple workers, that defeats the purpose
maybe you're more familiar and have a clear idea of how to deal with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any ideas @Makisuo?
for the recent
redirectsfeatures we are creating the recordThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry completely missed the previous comments, Github Notifications are a bit broken for me currently.
Think it makes sense if we automatically create a DNS record if not already existing.
Have often seen people be confused why routes weren't working since this pattern isn't quite clear anyways, so this makes a lot of sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! if you add that, i will merge the pr
ideally, also attach some screenshots/video of it working