fix(bus): propagate provider to queue subscriptions#6860
Draft
barnesoir wants to merge 2 commits intoanomalyco:devfrom
Draft
fix(bus): propagate provider to queue subscriptions#6860barnesoir wants to merge 2 commits intoanomalyco:devfrom
barnesoir wants to merge 2 commits intoanomalyco:devfrom
Conversation
c88aa6c to
4f495e8
Compare
The queue policy must use the IAM role ARN as the principal, not the events.amazonaws.com service principal. When EventBridge assumes an IAM role to send messages cross-account, the request comes from the role ARN. Changes: - Queue policy now uses targetRole.arn as the principal (type: AWS) - This fixes cross-account EventBridge→SQS delivery Tested: Events now successfully flow from EventBridge to SQS queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using subscribeQueue on a Bus created with a custom provider (cross-account scenario), the provider was not being passed to the underlying BusQueueSubscriber. This caused EventBridge rules and targets to be created in the wrong AWS account.
Changes:
This ensures queue subscriptions respect the bus provider in cross-account setups.