Skip to content

fix MessageBox focus #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2024
Merged

fix MessageBox focus #106

merged 3 commits into from
Oct 13, 2024

Conversation

Diaskhan
Copy link
Contributor

@Diaskhan Diaskhan commented Oct 9, 2024

@anovik
Copy link
Owner

anovik commented Oct 10, 2024

Thanks for creating issue, but they are quite slow in reactions so I don't believe this will be fixed soon. Let's fix it from our side.

Copy link
Owner

@anovik anovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change and it works for me. Please check a couple of other messagebox occurrences in code and change them similarly. You can search by "messageBoxWindow"

@Diaskhan
Copy link
Contributor Author

Diaskhan commented Oct 12, 2024

Find another places where behaviour is not expected.

Is only thing that distracting me.
Is when we create folder, focus by default Is not on TextBox.

public void ShowInput(Window owner)
Could u recomend something ?

I've created issue in related repo
AvaloniaCommunity/MessageBox.Avalonia#194

@anovik
Copy link
Owner

anovik commented Oct 13, 2024

No, I don't know how to fix TextBox focus, I guess some changes for that are necessary in message box repo.

I am going to proceed with merging this PR, if any issues still happen, we will handle them separately.

@anovik anovik merged commit 6f276ed into anovik:main Oct 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants