Dev/fix warnigs #91
Merged
Dev/fix warnigs #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 15, 2024 21:18
anovik
reviewed
Sep 16, 2024
| @@ -48,11 +48,12 @@ static OptionsModel() | |||
|
|
|||
| public bool IsMaximized { get; set; } | |||
|
|
|||
| public string LeftPanePath { get; set; } = ""; | |||
| public string LeftPanePath { get; set; } = string.Empty; | |||
|
|
|||
There was a problem hiding this comment.
I don't think that string.Empty is more readable. Would prefer to leave "" in all cases.
|
|
||
| public bool IsDarkThemeEnabled { get; set; } | ||
| public bool AllowOnlyOneInstance { get; set; } |
There was a problem hiding this comment.
Would prefer one instance to be the behavior by default.
| @@ -51,10 +51,11 @@ public OptionsViewModel() | |||
| ConfirmationWhenDeleteNonEmpty = Model.ConfirmationWhenDeleteNonEmpty; | |||
| SaveWindowPositionSize = Model.SaveWindowPositionSize; | |||
| IsDarkThemeEnabled = Model.IsDarkThemeEnabled; | |||
| AllowOnlyOneInstance=Model.AllowOnlyOneInstance; | |||
There was a problem hiding this comment.
whitespaces are missing before and after =
anovik
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix warnigs
fix misc issues
fix beahviour of One instance(that suppress errors in main thread)
Added option AllowOnlyOneInstance
#89