Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/search basic mechanic #92

Merged
merged 33 commits into from
Sep 23, 2024
Merged

Conversation

Diaskhan
Copy link
Contributor

@Diaskhan Diaskhan commented Sep 16, 2024

Basic Search

  • Cancel token when closing a searchWindow
  • double click or enter must navigate to file or folder (if folder not must drill down, must select forlder but not going inside it)

BUGS

  • when a new window is showed, it doesnt activated (setfocus), so in general focus still leaved on Mainwindow.
  • fix backspace and enter behaviour when we renamin file or folder inside Datagrid
  • when user hit enter, must drill down to the folder, and select first item (.. folder)
  • when user hit backspace the focus must be on folder that we was previously selected

Copy link
Owner

@anovik anovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising, could you please address my comments?

@Diaskhan Diaskhan marked this pull request as draft September 17, 2024 14:08
@Diaskhan
Copy link
Contributor Author

sorry, its draft
@anovik could u Add some requiremnts for this FileSearch Window ?

@anovik
Copy link
Owner

anovik commented Sep 17, 2024

No problem. I think we can keep it simple in the first iteration. Options for file search can be: search in file names (later can add regex and search in file content), search either in current dir only or in all subdirectories.

In the first iteration, we can display file list in the window with possibility of click and navigating to it/its folder.

Later we can add moving all found files to panel.

@Diaskhan Diaskhan marked this pull request as ready for review September 21, 2024 00:05
Copy link
Owner

@anovik anovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor comments.

@anovik anovik merged commit e4caa02 into anovik:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants