bugfix - Prevent passwordstore lookup to create subkey when create ==…

… false

Fixes#9105

changelogs/fragments/9106-passwordstore-fix-subkey-creation-even-when-create-==-false.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - passwordstore lookup plugin - Fix subkey creation even when `create == false` (https://github.com/ansible-collections/community.general/pull/9106). 

plugins/lookup/passwordstore.py

@@ -582,9 +582,9 @@ def run(self, terms, variables, **kwargs):
                     if self.paramvals['overwrite']:
                         with self.opt_lock('write'):
                             result.append(self.update_password())
-                    elif self.paramvals["subkey"] != "password" and not self.passdict.get(self.paramvals['subkey']):  # password exists but not the subkey
-                        with self.opt_lock('write'):
-                            result.append(self.update_password())
+                        if self.paramvals["subkey"] != "password" and not self.passdict.get(self.paramvals['subkey']):  # password exists but not the subkey
+                            with self.opt_lock('write'):
+                                result.append(self.update_password())
                     else:
                         result.append(self.get_passresult())
                 else:                     # password does not exist