add sssd_info module #11120
Open
add sssd_info module #11120
+326
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
module
Collaborator
|
The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test |
ansibullbot
added
the
needs_revision
felixfontein
added
check-before-release
russoz
reviewed
Nov 14, 2025
Collaborator
russoz
left a comment
russoz
left a comment
There was a problem hiding this comment.
Hi @MikeyTide
Thanks for the contribution! I left some comments in there for you, and I strongly suggest you read more documentation as you proceed.
| @@ -0,0 +1,230 @@ | |||
| #!/usr/bin/python | |||
| # -*- coding: utf-8 -*- | |||
Collaborator
There was a problem hiding this comment.
no longer needed as Python 2 is no longer supported
Comment on lines
+7
to
+8
| from __future__ import (absolute_import, division, print_function) | ||
| __metaclass__ = type |
Collaborator
There was a problem hiding this comment.
Also changed with the end of support for Python 2
Suggested change
| from __future__ import (absolute_import, division, print_function) | |
| __metaclass__ = type | |
| from __future__ import annotations |
|
|
||
|
|
||
| from ansible.module_utils.basic import AnsibleModule | ||
| import dbus |
Collaborator
There was a problem hiding this comment.
You need to read the docs for contributing. A good place to start is: https://github.com/ansible-collections/community.general/blob/main/CONTRIBUTING.md
|
|
||
| def _get_domain_path(self, domain): | ||
| """Convert domain name to D-Bus path format""" | ||
| return "/org/freedesktop/sssd/infopipe/Domains/%s" % domain.replace('.', '_2e') |
Collaborator
There was a problem hiding this comment.
Please use f-strings
Suggested change
| return "/org/freedesktop/sssd/infopipe/Domains/%s" % domain.replace('.', '_2e') | |
| return f"/org/freedesktop/sssd/infopipe/Domains/{domain.replace('.', '_2e')}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pull request adds a new module
sssd_infothat allows users to check SSSD domain status and retrieve domain information using D-Bus.The module provides the following actions:
domain_status- Check if a specific domain is onlinedomain_list- List all configured SSSD domainsactive_servers- Get active servers for a specific domain and server type (IPA/AD)list_servers- List all servers for a specific domain and server type (IPA/AD)ISSUE TYPE
COMPONENT NAME
sssd_info
ADDITIONAL INFORMATION
The module uses D-Bus to communicate with SSSD's infopipe interface, providing reliable and direct access to SSSD status information without relying on command-line tools.
Key features:
Example usage: