snmp_facts: improvements #11148
Merged
snmp_facts: improvements #11148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
russoz
commented
Nov 13, 2025
This comment was marked as resolved.
This comment was marked as resolved.
ansibullbot
added
the
needs_revision
russoz
force-pushed
the
snmp-facts-validation
branch
from
b0e5610 to
1e79961
Compare
ansibullbot
removed
the
needs_revision
felixfontein
added
check-before-release
felixfontein
added
breaking_change
russoz
force-pushed
the
snmp-facts-validation
branch
from
1e79961 to
269f021
Compare
russoz
force-pushed
the
snmp-facts-validation
branch
from
269f021 to
073ab41
Compare
This was referenced Nov 22, 2025
Merged
Merged
russoz
force-pushed
the
snmp-facts-validation
branch
from
073ab41 to
537392f
Compare
russoz
commented
Nov 22, 2025
| required_if=[ | ||
| ("version", "v2", ["community"]), | ||
| ("version", "v2c", ["community"]), | ||
| ("version", "v3", ["username", "authkey", "level"]), |
Collaborator
Author
There was a problem hiding this comment.
Adding level because if it is not passed:
- in line 305 the validation of param
privacywhenlevel=authPrivis not enforced, but ... - ... in line 327, because it is a plain
else, it creates a silent, undocumented defaultlevel=authPrivwhenlevelis not passed
This could lead to a blatantly wrong situation. I suppose this still configures a breaking change, but in this case it's one that should be performed, IMO.
felixfontein
approved these changes
Nov 23, 2025
felixfontein
added
backport-12
Collaborator
|
I think this is OK for 12.x.y, but I wouldn't backport it to older versions. |
felixfontein
removed
the
check-before-release
Backport to stable-12: 💚 backport PR created✅ Backport PR branch: Backported as #11196 🤖 @patchback |
Collaborator
|
@russoz thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Nov 23, 2025
* snmp_facts: improvements * require level if vesion=v3 (cherry picked from commit 7321ba4)
felixfontein
pushed a commit
that referenced
this pull request
Nov 23, 2025
…1196) snmp_facts: improvements (#11148) * snmp_facts: improvements * require level if vesion=v3 (cherry picked from commit 7321ba4) Co-authored-by: Alexei Znamensky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Parameter validation using Ansible constructs, plus a couple of Python idioms adjustments.
ISSUE TYPE
COMPONENT NAME
snmp_facts