Skip to content

Conversation

@dev-zero
Copy link

VxLan virtual devices can be added to bridge ports, like any other devices. And when using multicast remote addresses, NetworkManager need to know the parent device as well.

SUMMARY

Adds a vxlan_parent attribute to nmcli to support multicast remote VxLan addresses.
Enables slave_type and master for vxlan types to permit adding the vxlan device to a bridge.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nmcli

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 21, 2025
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-12 Automatically create a backport for the stable-12 branch labels Nov 21, 2025
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

@dev-zero
Copy link
Author

@felixfontein done. Do you have any idea why the nmcli.py in the failing test runners is inconsistent?
I have vxlan_parent=dict(type="str") in the module spec in my patch, but looking at the code in the error unit test log this line seems to be missing, giving a KeyError when parsing the args in __init__

@dev-zero dev-zero force-pushed the bugfix/support-multicast-vxlan branch from d49b6f3 to bc5abc3 Compare November 24, 2025 14:24
VxLan virtual devices can be added to bridge ports, like any other
devices. And when using multicast remote addresses,
NetworkManager need to know the parent device as well.

Co-authored-by: Felix Fontein <[email protected]>
@dev-zero dev-zero force-pushed the bugfix/support-multicast-vxlan branch from bc5abc3 to e7308b9 Compare November 25, 2025 08:32
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Nov 25, 2025
@dev-zero
Copy link
Author

dev-zero commented Nov 25, 2025

@felixfontein nevermind, found the culprit, a complete argument_spec replica in one of the unittests.

@russoz
Copy link
Collaborator

russoz commented Nov 25, 2025

@felixfontein nevermind, found the culprit, a complete argument_spec replica in one of the unittests.

Keeping that replica is very wrong. Sigh. One way we'll remove it.

Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @dev-zero thanks for your contribution!

Other than the adjustment in the changelog fragment, it LGTM

Comment on lines +2 to +3
- nmcli module - add vxlan_parent argument required for multicast vxlan_remote addresses
- nmcli module - add vxlan to list of bridgeable devices
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this one single line. And the formatting style needs adjusting.

Please refer to the standard formatting for the changelog fragments' entries:

https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs-how-to-format

The outcome of what you write will be published in the collection changelog:

https://docs.ansible.com/ansible/latest/collections/community/general/changelog.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-12 Automatically create a backport for the stable-12 branch check-before-release PR will be looked at again shortly before release and merged if possible. feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants