-
Notifications
You must be signed in to change notification settings - Fork 1.7k
nmcli: allow VxLan multicast and bridge port #11182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
nmcli: allow VxLan multicast and bridge port #11182
Conversation
felixfontein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Can you please add a changelog fragment? Thanks.
|
@felixfontein done. Do you have any idea why the |
d49b6f3 to
bc5abc3
Compare
VxLan virtual devices can be added to bridge ports, like any other devices. And when using multicast remote addresses, NetworkManager need to know the parent device as well. Co-authored-by: Felix Fontein <[email protected]>
bc5abc3 to
e7308b9
Compare
|
@felixfontein nevermind, found the culprit, a complete |
Keeping that replica is very wrong. Sigh. One way we'll remove it. |
russoz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @dev-zero thanks for your contribution!
Other than the adjustment in the changelog fragment, it LGTM
| - nmcli module - add vxlan_parent argument required for multicast vxlan_remote addresses | ||
| - nmcli module - add vxlan to list of bridgeable devices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make this one single line. And the formatting style needs adjusting.
Please refer to the standard formatting for the changelog fragments' entries:
https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs-how-to-format
The outcome of what you write will be published in the collection changelog:
https://docs.ansible.com/ansible/latest/collections/community/general/changelog.html
VxLan virtual devices can be added to bridge ports, like any other devices. And when using multicast remote addresses, NetworkManager need to know the parent device as well.
SUMMARY
Adds a
vxlan_parentattribute tonmclito support multicast remote VxLan addresses.Enables
slave_typeandmasterforvxlantypes to permit adding the vxlan device to a bridge.ISSUE TYPE
COMPONENT NAME
nmcli