Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache2_mod_proxy: big revamp #9457

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

apache2_mod_proxy: big revamp #9457

wants to merge 8 commits into from

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Dec 29, 2024

SUMMARY

Simplified the module, but keeping the exact same logic

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

apache2_mod_proxy

@ansibullbot
Copy link
Collaborator

cc @oboukili
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress module module plugins plugin (any type) labels Dec 29, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Dec 29, 2024
@russoz russoz changed the title [WIP] apache2_mod_proxy: big revamp apache2_mod_proxy: big revamp Dec 30, 2024
@ansibullbot ansibullbot removed the WIP Work in progress label Dec 30, 2024
@russoz russoz requested a review from felixfontein January 1, 2025 08:27
felixfontein
felixfontein reviewed Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How intensively did you test this module? There are unfortunately no tests for this module around...

plugins/modules/apache2_mod_proxy.py Outdated Show resolved Hide resolved
@russoz
Copy link
Collaborator Author

russoz commented Jan 4, 2025

How intensively did you test this module? There are unfortunately no tests for this module around...

I did not test it. The logic is relatively simple and it was maintained to the best of my ability.

@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 6, 2025
@russoz russoz force-pushed the apache2-mod-proxy-revamp branch from 8655d8c to 67cafa8 Compare January 10, 2025 09:39
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jan 18, 2025
@russoz russoz force-pushed the apache2-mod-proxy-revamp branch from 67cafa8 to c00405d Compare January 22, 2025 22:08
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Jan 22, 2025
@russoz russoz force-pushed the apache2-mod-proxy-revamp branch 2 times, most recently from 6124e55 to c25e6b1 Compare January 23, 2025 10:05
@ansibullbot ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 23, 2025
@russoz russoz force-pushed the apache2-mod-proxy-revamp branch from c25e6b1 to 19d1106 Compare January 24, 2025 02:16
@ansibullbot ansibullbot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 24, 2025
@russoz russoz mentioned this pull request Jan 25, 2025
Merged
@russoz russoz force-pushed the apache2-mod-proxy-revamp branch from 4f210c9 to 31af30c Compare January 26, 2025 21:03
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jan 26, 2025
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jan 26, 2025
@russoz russoz requested a review from felixfontein January 26, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein Awaiting requested review from felixfontein

Assignees
No one assigned
Labels
backport-10 Automatically create a backport for the stable-10 branch check-before-release PR will be looked at again shortly before release and merged if possible. module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein