Create `onepassword_ssh_key` plugin #9580

mohammedbabelly20 · 2025-01-17T11:28:42Z

SUMMARY

ISSUE TYPE

New Module/Plugin Pull Request

COMPONENT NAME

Added a new plugin onepassword_ssh_key to fetch private keys stored in onepassword in both SSH format and PKCS#8 format.

mohammedbabelly20 · 2025-01-17T11:29:39Z

CC @samdoran

russoz

hi @mohammedbabelly20 thanks for contributing!

I have some comments on your plugin. Please notice that all new plugins are required to include tests - integration tests are preferred, but unit tests are accepted.

plugins/doc_fragments/onepassword_ssh_key.py

plugins/lookup/onepassword_ssh_key.py

felixfontein

Thanks for your contribution!

plugins/doc_fragments/onepassword_ssh_key.py

plugins/lookup/onepassword_ssh_key.py

This reverts commit e17ff7e.

plugins/lookup/onepassword_ssh_key.py

tests/unit/plugins/lookup/test_onepassword.py

russoz

Hi there, couple of comments here

plugins/lookup/onepassword_ssh_key.py

felixfontein · 2025-01-25T09:36:15Z

You still need to add the new plugin to BOTMETA, see https://github.com/ansible-collections/community.general/blob/main/CONTRIBUTING.md#creating-new-modules-or-plugins. That will make the last failing test go away.

.github/BOTMETA.yml

…dbabelly20/ansible-community.general into 1password-ssh_key-plugin

ansibullbot · 2025-01-25T19:52:31Z

@mohammedbabelly20 this PR contains the following merge commits:

644237e

Please rebase your branch to remove these commits.

click here for bot help

patchback · 2025-01-26T14:24:21Z

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/25a262bdcf76775c8156627e5ab026d73e745b02/pr-9580

Backported as #9632

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* add 1password_ssh_key lookup * refactor * Delete onepassword_ssh_key.py * Revert "Delete onepassword_ssh_key.py" This reverts commit e17ff7e. * Delete onepassword_ssh_key.py * add tests * add test license * cleanup * refactor * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * fix indentation * fix RETURN indentation * use get_option to get ssh_format * linting * update project year in copyright * add plugin to BOTMETA.yml * use OnePassCLIv2's get_raw and use OnePass's token --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 25a262b)

felixfontein · 2025-01-26T14:24:33Z

@mohammedbabelly20 thanks for your contribution!
@russoz thanks for reviewing!

…plugin (#9632) Create `onepassword_ssh_key` plugin (#9580) * add 1password_ssh_key lookup * refactor * Delete onepassword_ssh_key.py * Revert "Delete onepassword_ssh_key.py" This reverts commit e17ff7e. * Delete onepassword_ssh_key.py * add tests * add test license * cleanup * refactor * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * fix indentation * fix RETURN indentation * use get_option to get ssh_format * linting * update project year in copyright * add plugin to BOTMETA.yml * use OnePassCLIv2's get_raw and use OnePass's token --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 25a262b) Co-authored-by: Mohammed Babelly <[email protected]>

* add 1password_ssh_key lookup * refactor * Delete onepassword_ssh_key.py * Revert "Delete onepassword_ssh_key.py" This reverts commit e17ff7e. * Delete onepassword_ssh_key.py * add tests * add test license * cleanup * refactor * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * fix indentation * fix RETURN indentation * use get_option to get ssh_format * linting * update project year in copyright * add plugin to BOTMETA.yml * use OnePassCLIv2's get_raw and use OnePass's token --------- Co-authored-by: Felix Fontein <[email protected]>

add 1password_ssh_key lookup

66c807a

This comment was marked as outdated.

Sign in to view

russoz reviewed Jan 18, 2025

View reviewed changes

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Jan 18, 2025

felixfontein reviewed Jan 18, 2025

View reviewed changes

plugins/doc_fragments/onepassword_ssh_key.py Outdated Show resolved Hide resolved

refactor

786d212

felixfontein reviewed Jan 20, 2025

View reviewed changes

plugins/lookup/onepassword_ssh_key.py Outdated Show resolved Hide resolved

mohammedbabelly20 added 4 commits January 20, 2025 10:13

Delete onepassword_ssh_key.py

e17ff7e

Revert "Delete onepassword_ssh_key.py"

f3a6b98

This reverts commit e17ff7e.

Delete onepassword_ssh_key.py

ad809a0

add tests

81518ba

This comment was marked as outdated.

Sign in to view

ansibullbot added new_plugin New plugin tests tests unit tests/unit labels Jan 20, 2025

add test license

aea8ee7

ansibullbot added ci_verified Push fixes to PR branch to re-run CI and removed ci_verified Push fixes to PR branch to re-run CI labels Jan 20, 2025

mohammedbabelly20 requested review from russoz and felixfontein January 20, 2025 09:29

felixfontein reviewed Jan 20, 2025

View reviewed changes

tests/unit/plugins/lookup/test_onepassword.py Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Jan 21, 2025

mohammedbabelly20 added 4 commits January 21, 2025 13:59

fix indentation

044dab7

fix RETURN indentation

d8550ae

use get_option to get ssh_format

5f93670

linting

9269960

ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Jan 21, 2025

mohammedbabelly20 requested a review from felixfontein January 21, 2025 10:24

russoz reviewed Jan 23, 2025

View reviewed changes

plugins/lookup/onepassword_ssh_key.py Outdated Show resolved Hide resolved

plugins/lookup/onepassword_ssh_key.py Show resolved Hide resolved

plugins/lookup/onepassword_ssh_key.py Outdated Show resolved Hide resolved

update project year in copyright

fa433d6

add plugin to BOTMETA.yml

26fcb9d

ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 25, 2025

mohammedbabelly20 commented Jan 25, 2025

View reviewed changes

.github/BOTMETA.yml Show resolved Hide resolved

mohammedbabelly20 added 2 commits January 25, 2025 23:36

use OnePassCLIv2's get_raw and use OnePass's token

bd7c240

Merge branch '1password-ssh_key-plugin' of https://github.com/mohamme…

644237e

…dbabelly20/ansible-community.general into 1password-ssh_key-plugin

ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jan 25, 2025

felixfontein merged commit 25a262b into ansible-collections:main Jan 26, 2025
138 checks passed

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 26, 2025

patchback bot mentioned this pull request Jan 26, 2025

[PR #9580/25a262bd backport][stable-10] Create onepassword_ssh_key plugin #9632

Merged

felixfontein mentioned this pull request Jan 26, 2025

onepassword_ssh_key: avoid inheriting from OnePassCLIv2 #9633

Merged

patchback bot mentioned this pull request Jan 27, 2025

[PR #9633/8749da77 backport][stable-10] onepassword_ssh_key: avoid inheriting from OnePassCLIv2 #9639

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create `onepassword_ssh_key` plugin #9580

Create `onepassword_ssh_key` plugin #9580

mohammedbabelly20 commented Jan 17, 2025 •

edited

Loading

mohammedbabelly20 commented Jan 17, 2025

This comment was marked as outdated.

russoz left a comment

felixfontein left a comment

This comment was marked as outdated.

This comment was marked as outdated.

russoz left a comment

felixfontein commented Jan 25, 2025

ansibullbot commented Jan 25, 2025

patchback bot commented Jan 26, 2025 •

edited

Loading

felixfontein commented Jan 26, 2025

Create onepassword_ssh_key plugin #9580

Create onepassword_ssh_key plugin #9580

Conversation

mohammedbabelly20 commented Jan 17, 2025 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

mohammedbabelly20 commented Jan 17, 2025

This comment was marked as outdated.

russoz left a comment

Choose a reason for hiding this comment

felixfontein left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

russoz left a comment

Choose a reason for hiding this comment

felixfontein commented Jan 25, 2025

ansibullbot commented Jan 25, 2025

patchback bot commented Jan 26, 2025 • edited Loading

Backport to stable-10: 💚 backport PR created

felixfontein commented Jan 26, 2025

Create `onepassword_ssh_key` plugin #9580

Create `onepassword_ssh_key` plugin #9580

mohammedbabelly20 commented Jan 17, 2025 •

edited

Loading

patchback bot commented Jan 26, 2025 •

edited

Loading