Fix errors reported by ansible-test sanity #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le_cloud_ops_agents submodule
|
Welp, it doesn't show when running the GH action, but the ignore I added fails, so backing that change out. |
|
The failing integration test is a stockout on TPUs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nearly all of the changes are documentation related.
Fixes #613 mostly, there may be one remaining
no-illegal-filenameserror in the submodule directory. On my workstation I'm getting:roles/google_cloud_ops_agents/is the path to the submodule;roles/google_cloud_ops_agents/.//is basically a synonym for that path but it's unclear howansible-testis coming up with it.This does fix all of the issues in
validate-modules, which is what #613 is specifically about.