Skip to content

feat(gce): Add label support to gce plugin #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(gce): Add label support to gce plugin #327

wants to merge 8 commits into from

Conversation

hunter86bg
Copy link

No description provided.

@hunter86bg
Add GCE label support
ff43e2d
@hunter86bg
Fix the name of a task
be1db24
@hunter86bg
Add GCE label support
2b8ca52 
Allow creation of GCE molecule instances with labels assigned to them
@hunter86bg
Copy link
Author

/label enhancement

@hunter86bg
Copy link
Author

hunter86bg commented Aug 26, 2025 •
edited
Loading

@apatard , how can I add a label to this enhancement and what should I do to get it merged ?

@hunter86bg
Copy link
Author

@ssbarnea can you help with the next steps ?

@hunter86bg
Copy link
Author

It seems the lint job doesn't install Ansible collections and fails on google.cloud.gcp_compute_instance_info .

@ssbarnea ssbarnea added fix and removed enhancement labels Sep 8, 2025
@ssbarnea ssbarnea mentioned this pull request Sep 8, 2025
Merged
@ssbarnea ssbarnea changed the title Add GCE label support feat(gce): Add label support to gce plugin Sep 8, 2025
@hunter86bg
Copy link
Author

This feature allows end users to specify labels for each platform.
Also, I've added a test that allows to verify the labels are created properly.

@hunter86bg
Copy link
Author

@ssbarnea what can I do to get this feature merged ? The lint fails due to missing google.cloud.gcp_compute_instance_info and I can remove everything from the test directory.

@hunter86bg
feat: Add label support to gce plugin
31b885e 
Remove some unnecessary comments
@github-actions github-actions bot added feature and removed fix labels Sep 25, 2025
@github-actions GitHub Actions
Copy link

Label error. Requires exactly 1 of: breaking, build, chore, ci, docs, feat, fix, perf, refactor, style, test. Found: feature. Follow https://www.conventionalcommits.org to get auto-labeling to work correctly.

@hunter86bg
Copy link
Author

Seems the label check is failing cause it expects feat

Requires exactly 1 of: breaking, build, chore, ci, docs, feat, fix, perf, refactor, style, test. Found: feature.

@github-actions github-actions bot added feature and removed feature labels Sep 25, 2025
@github-actions github-actions bot added feature and removed feature labels Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hunter86bg @ssbarnea @cidrblock