Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RHEL-08-020050 to loop over stdout_lines. Fixes issue #261. #262

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

Phenix66
Copy link
Contributor

@Phenix66 Phenix66 commented Mar 20, 2024

Overall Review of Changes:
Using stdout_lines will ensure that the looped variable is always a list, even with a single entry.

Issue Fixes:
#261

Enhancements:
Please list any enhancements/features that are not open issue tickets

How has this been tested?:
Mocked scenarios locally

@uk-bolly
Copy link
Member

hi @Phenix66

This is a great catch in the rhel8-stig, thank you for taking the time to raise the issue and subsequent PR. We are happy to accept this fix but unfortunately have noted that the PR is not signed-off-by or gpg signed ( -s -S in a commit). We do require all commits are signed in this way before we are able to accept them.
If you could ensure all commits are signed we can accept this, should you have any difficulties happy to create the PR and give credit.

Many thanks

uk-bolly

tasks/fix-cat2.yml Show resolved Hide resolved
@Phenix66
Copy link
Contributor Author

Commit should be GPG signed now

Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix and updates thank you

@uk-bolly uk-bolly merged commit 7c42617 into ansible-lockdown:devel Mar 21, 2024
4 checks passed
@Phenix66 Phenix66 deleted the fix-issue-261 branch March 23, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants