Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about arguments in shebang in modules #1718

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

mabezi
Copy link
Contributor

@mabezi mabezi commented Jul 25, 2024

In ansible/ansible#83603 the result of the discussion was that it is neither wanted nor supported to use arguments in the shebang.

Obviously, this feature is not a matter of common knowledge. I'm far from the only one who didn't know that. (e.g. VMware's NSX-T Ansible Modules or even the test-playbook from ansible itself)

imho this is also due to ambiguous documentation.

With this PR, I would like to make the documentation a little clearer. I'm always open to suggestions for improvement.

@ansible-documentation-bot ansible-documentation-bot bot added the new_contributor This PR is the first contribution by a new community member. label Jul 25, 2024
@ansible-documentation-bot
Copy link
Contributor

Thanks for your Ansible docs contribution! We talk about Ansible documentation on matrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs! We meet there on Tuesdays (see the Ansible calendar) and welcome additions to our weekly agenda items - scroll down to find the upcoming agenda and add a comment to put something new on that agenda.

@samccann
Copy link
Contributor

Hi @mabezi ! when you accept the suggested edits above, you'll then need to rebase this PR due to a change in the underling CI tests.

Thanks!

Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked my suggestion as resolved. Feel free to apply it still, or not. Thanks.

@mabezi
Copy link
Contributor Author

mabezi commented Aug 20, 2024

Updated everything @oraNod @samccann

@oraNod oraNod merged commit 9076624 into ansible:devel Aug 21, 2024
9 checks passed
@oraNod
Copy link
Contributor

oraNod commented Aug 21, 2024

Thanks for the docs contribution @mabezi !

@oraNod oraNod added backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch labels Aug 21, 2024
Copy link

patchback bot commented Aug 21, 2024

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/90766243510da5f78cb8fbf69ff409a6748e327d/pr-1718

Backported as #1773

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented Aug 21, 2024

Backport to stable-2.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.15/90766243510da5f78cb8fbf69ff409a6748e327d/pr-1718

Backported as #1774

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented Aug 21, 2024

Backport to stable-2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.16/90766243510da5f78cb8fbf69ff409a6748e327d/pr-1718

Backported as #1775

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 21, 2024
* add note about arguments in shebang in modules

* update note about arguments in shebang in modules

* move notes about shebang in one warning

(cherry picked from commit 9076624)
patchback bot pushed a commit that referenced this pull request Aug 21, 2024
* add note about arguments in shebang in modules

* update note about arguments in shebang in modules

* move notes about shebang in one warning

(cherry picked from commit 9076624)
patchback bot pushed a commit that referenced this pull request Aug 21, 2024
* add note about arguments in shebang in modules

* update note about arguments in shebang in modules

* move notes about shebang in one warning

(cherry picked from commit 9076624)
oraNod pushed a commit that referenced this pull request Aug 21, 2024
* add note about arguments in shebang in modules

* update note about arguments in shebang in modules

* move notes about shebang in one warning

(cherry picked from commit 9076624)

Co-authored-by: mabezi <[email protected]>
oraNod pushed a commit that referenced this pull request Aug 21, 2024
* add note about arguments in shebang in modules

* update note about arguments in shebang in modules

* move notes about shebang in one warning

(cherry picked from commit 9076624)

Co-authored-by: mabezi <[email protected]>
oraNod pushed a commit that referenced this pull request Aug 21, 2024
* add note about arguments in shebang in modules

* update note about arguments in shebang in modules

* move notes about shebang in one warning

(cherry picked from commit 9076624)

Co-authored-by: mabezi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch new_contributor This PR is the first contribution by a new community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants