Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Windows docs #1820

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Revamp Windows docs #1820

merged 4 commits into from
Sep 13, 2024

Conversation

jborean93
Copy link
Contributor

Rearranges the docs for Windows to expand on the different connection types outside of winrm. Also removes a lot of the old and outdated information that is no longer needed as the affected OS versions are end of life and no longer supported by Ansible.

This change has most likely broken some links in the existing docs. I am unsure how you want to deal with this.

@jborean93
Copy link
Contributor Author

I'll look into the failures next week but happy to take any feedback or suggestions on how to approach these changes anytime.

docs/docsite/rst/os_guide/intro_windows.rst Outdated Show resolved Hide resolved
docs/docsite/rst/os_guide/intro_windows.rst Outdated Show resolved Hide resolved
docs/docsite/rst/os_guide/intro_windows.rst Outdated Show resolved Hide resolved
docs/docsite/rst/os_guide/intro_windows.rst Outdated Show resolved Hide resolved
docs/docsite/rst/os_guide/intro_windows.rst Outdated Show resolved Hide resolved
docs/docsite/rst/os_guide/windows_ssh.rst Outdated Show resolved Hide resolved
docs/docsite/rst/os_guide/windows_winrm_kerberos.rst Outdated Show resolved Hide resolved
docs/docsite/rst/os_guide/windows_winrm_kerberos.rst Outdated Show resolved Hide resolved
docs/docsite/rst/os_guide/index.rst Show resolved Hide resolved
docs/docsite/rst/os_guide/windows_ssh.rst Show resolved Hide resolved
@jborean93
Copy link
Contributor Author

Thanks @oraNod for reading through the changes here, I know it's not a small block of changes.

@oraNod
Copy link
Contributor

oraNod commented Sep 12, 2024

Hi @jborean93 We've made some changes to the underlying readthedocs project for this repository. I'm going to close and re-open this issue to kick off a new PR preview build.

You might notice there will be two checks for readthedocs. One for docs/readthedocs.org:stage-ansible-core and another for docs/readthedocs.org:ansible-core.

The stage-ansible-core check is for the old project and will result in a 404. Please ignore that and use the ansible-core check only.

Thank you for your patience and understanding.

jborean93 and others added 4 commits September 13, 2024 09:26
Rearranges the docs for Windows to expand on the different connection
types outside of winrm. Also removes a lot of the old and outdated
information that is no longer needed as the affected OS versions are end
of life and no longer supported by Ansible.
@jborean93
Copy link
Contributor Author

@oraNod, no worries, I've just rebased and updated based on your last review.

Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jborean93

Do you want to get additional review on this or are you happy to merge?

@oraNod oraNod added the backport-2.17 Automatically create a backport for the stable-2.17 branch label Sep 13, 2024
@oraNod
Copy link
Contributor

oraNod commented Sep 13, 2024

Also, should we backport this to the stable-2.17 or any other branches or just keep it on devel and stable-2.18 when we cut that branch?

@jborean93
Copy link
Contributor Author

I’m happy to merge it. As for a backport it does orphan some pages so maybe let’s just leave it in devel for when 2.18 is out.

@oraNod oraNod added no_backport This PR should not be backported. devel only. and removed backport-2.17 Automatically create a backport for the stable-2.17 branch labels Sep 13, 2024
@oraNod oraNod merged commit 8ed3fc7 into ansible:devel Sep 13, 2024
9 checks passed
@oraNod
Copy link
Contributor

oraNod commented Sep 13, 2024

Thank you @jborean93

@jborean93 jborean93 deleted the win-docs branch September 13, 2024 20:17
@jborean93
Copy link
Contributor Author

Thanks for the review and help @oraNod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no_backport This PR should not be backported. devel only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants