-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Windows docs #1820
Revamp Windows docs #1820
Conversation
I'll look into the failures next week but happy to take any feedback or suggestions on how to approach these changes anytime. |
Thanks @oraNod for reading through the changes here, I know it's not a small block of changes. |
Hi @jborean93 We've made some changes to the underlying readthedocs project for this repository. I'm going to close and re-open this issue to kick off a new PR preview build. You might notice there will be two checks for readthedocs. One for The Thank you for your patience and understanding. |
Rearranges the docs for Windows to expand on the different connection types outside of winrm. Also removes a lot of the old and outdated information that is no longer needed as the affected OS versions are end of life and no longer supported by Ansible.
Co-authored-by: Don Naro <[email protected]>
@oraNod, no worries, I've just rebased and updated based on your last review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @jborean93
Do you want to get additional review on this or are you happy to merge?
Also, should we backport this to the |
I’m happy to merge it. As for a backport it does orphan some pages so maybe let’s just leave it in devel for when 2.18 is out. |
Thank you @jborean93 |
Thanks for the review and help @oraNod |
Rearranges the docs for Windows to expand on the different connection types outside of winrm. Also removes a lot of the old and outdated information that is no longer needed as the affected OS versions are end of life and no longer supported by Ansible.
This change has most likely broken some links in the existing docs. I am unsure how you want to deal with this.